Skip to content

[GEODE-10641] Fix CertificateBuilder - #8070

Open
JinwooHwang wants to merge 1 commit into
apache:developfrom
JinwooHwang:feature/GEODE-10641
Open

[GEODE-10641] Fix CertificateBuilder#8070
JinwooHwang wants to merge 1 commit into
apache:developfrom
JinwooHwang:feature/GEODE-10641

Conversation

@JinwooHwang

Copy link
Copy Markdown
Contributor

Fix CertificateBuilder

For all changes, please confirm:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
  • Has your PR been rebased against the latest commit within the target branch (typically develop)?
  • Is your initial contribution a single, squashed commit?
  • Does gradlew build run cleanly?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@sboorlagadda sboorlagadda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a CertificateBuilderJUnitTest that generates a cert with dns+ip SAN, CA flag, and serverAuth EKU, then asserts
getSubjectAlternativeNames, getExtendedKeyUsage, getBasicConstraints != -1, and a verify(issuerPublicKey) round-trip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants