fix(java): reproduce silent Set child-loss for package-private nodes - #3902
Open
PiotrDuz wants to merge 1 commit into
Open
fix(java): reproduce silent Set child-loss for package-private nodes#3902PiotrDuz wants to merge 1 commit into
PiotrDuz wants to merge 1 commit into
Conversation
…in cyclic graphs Wide fan-out (one parent, many children) cyclic graph of package-private nodes loses entries from a Set<PackagePrivateType> field on deserialize - no exception, unlike the codegen CompileException PackagePrivateMapKeyTest guards against. Reproduced from a production graph with 100+ children under one node; the child->parent back-reference (EnumMap-keyed) survives the round trip, the parent->child Set does not.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cyclic graphs
Wide fan-out (one parent, many children) cyclic graph of package-private nodes loses entries from a Set field on deserialize - no exception.
Why?
fory had a regression bug of cyclic graph losing edges. Want to pin it so no further regressions are possible.
What does this PR do?
This PR adds a test case that reproduces the regression
Related issues
#3903
AI Contribution Checklist
The test has been generated by AI, but the idea and guidance is human - the problem and its reporduction in version 1.1.0 is tested by hand.