feat(java): add configurable deserialization size guardrails (#3411)#3438
Open
SURYAS1306 wants to merge 2 commits intoapache:mainfrom
Open
feat(java): add configurable deserialization size guardrails (#3411)#3438SURYAS1306 wants to merge 2 commits intoapache:mainfrom
SURYAS1306 wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Currently there are no configurable limits for payload-driven lengths in Java deserialization.
Untrusted binary/map/list lengths can trigger large allocations and memory pressure.
This PR introduces configurable guardrails to prevent excessive memory allocation during deserialization.
What does this PR do?
Adds two runtime configuration options:
maxBinarySizemaxCollectionSizeEnforces:
maxCollectionSizefor:maxBinarySizefor:Int8List,Uint8List)String reads are intentionally excluded as specified in issue [Java] configurable size guardrails for untrusted payloads #3411.
Throws
IllegalArgumentExceptionwhen configured limits are exceeded.No behavior change when limits are unset or set to
0.All existing tests pass.
Related issues
Fixes #3411
Does this PR introduce any user-facing change?
This introduces new configuration options but does not modify the binary protocol.
Benchmark
Not applicable. This change does not modify serialization logic or performance-critical paths beyond adding guard checks.