-
Notifications
You must be signed in to change notification settings - Fork 394
feat(rust): add configurable size guardrails (max_string_bytes, max_collection_size, max_map_size) #3421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zakir032002
wants to merge
19
commits into
apache:main
Choose a base branch
from
Zakir032002:issue-3409-size-guardrails
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(rust): add configurable size guardrails (max_string_bytes, max_collection_size, max_map_size) #3421
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
f98e8fd
feat(rust): add configurable size guardrails (max_string_bytes, max_c…
Zakir032002 7a1abb2
fix(rust): correct 4 guardrail bugs found in PR review
Zakir032002 66c35f8
fix(rust): remove duplicate check_bound + move BTreeMap guard before …
Zakir032002 7ffbc8c
final
Zakir032002 8dba330
fix ci
Zakir032002 b59ac23
fix ci
Zakir032002 65172ea
Add buffer-remaining check
Zakir032002 b48f931
remove buff check
Zakir032002 c547e7e
addong buff rem checks
Zakir032002 6c2a02c
fix ci
Zakir032002 1a5b212
fix(rust): add buffer-remaining check to read_vec_data; fix misleadin…
Zakir032002 5dc5257
fix(rust): add buffer-remaining check to primitive_list fory_read_dat…
Zakir032002 4ca62af
fix(rust): add missing #[inline(always)] to ReadContext::check_string…
Zakir032002 d77d313
test(rust): add buffer-remaining truncation tests for read_vec_data a…
Zakir032002 4057e18
fix(rust): add size guardrails for string, collection, and map deseri…
Zakir032002 bf994c5
feat(rust): add configurable size guardrails for untrusted payloads
Zakir032002 6bf3ec2
remove check_string_bytes
Zakir032002 7891f39
remove unused check_binary_size from ReadContext
Zakir032002 9b36d92
Update buffer.rs
Zakir032002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work for streaming deserialization