feat(java): add float support #3254
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.fory.collection; | ||
|
|
||
| import java.util.AbstractList; | ||
| import java.util.Arrays; | ||
| import java.util.Objects; | ||
| import java.util.RandomAccess; | ||
| import org.apache.fory.type.Float16; | ||
|
|
||
| public final class Float16List extends AbstractList<Float16> implements RandomAccess { | ||
| private static final int DEFAULT_CAPACITY = 10; | ||
|
|
||
| private short[] array; | ||
| private int size; | ||
|
|
||
| public Float16List() { | ||
| this(DEFAULT_CAPACITY); | ||
| } | ||
|
|
||
| public Float16List(int initialCapacity) { | ||
| if (initialCapacity < 0) { | ||
| throw new IllegalArgumentException("Illegal capacity: " + initialCapacity); | ||
| } | ||
| this.array = new short[initialCapacity]; | ||
| this.size = 0; | ||
| } | ||
|
|
||
| public Float16List(short[] array) { | ||
| this.array = array; | ||
| this.size = array.length; | ||
| } | ||
|
|
||
| @Override | ||
| public Float16 get(int index) { | ||
| checkIndex(index); | ||
| return Float16.fromBits(array[index]); | ||
| } | ||
|
|
||
| @Override | ||
| public int size() { | ||
| return size; | ||
| } | ||
|
|
||
| @Override | ||
| public Float16 set(int index, Float16 element) { | ||
| checkIndex(index); | ||
| Objects.requireNonNull(element, "element"); | ||
| short prev = array[index]; | ||
| array[index] = element.toBits(); | ||
| return Float16.fromBits(prev); | ||
| } | ||
|
|
||
| public void set(int index, short bits) { | ||
| checkIndex(index); | ||
| array[index] = bits; | ||
| } | ||
|
|
||
| public void set(int index, float value) { | ||
| checkIndex(index); | ||
| array[index] = Float16.valueOf(value).toBits(); | ||
| } | ||
|
|
||
| @Override | ||
| public void add(int index, Float16 element) { | ||
| checkPositionIndex(index); | ||
| ensureCapacity(size + 1); | ||
| System.arraycopy(array, index, array, index + 1, size - index); | ||
| array[index] = element.toBits(); | ||
| size++; | ||
| modCount++; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean add(Float16 element) { | ||
| Objects.requireNonNull(element, "element"); | ||
| ensureCapacity(size + 1); | ||
| array[size++] = element.toBits(); | ||
| modCount++; | ||
| return true; | ||
| } | ||
|
|
||
| public boolean add(short bits) { | ||
| ensureCapacity(size + 1); | ||
| array[size++] = bits; | ||
| modCount++; | ||
| return true; | ||
| } | ||
|
|
||
| public boolean add(float value) { | ||
|
Collaborator
There was a problem hiding this comment. Float16List primitive methods still allocate Float16 objects on the hot path. add(float), set(float), and getFloat(int) all go through Float16.valueOf/fromBits, so these paths allocate even though this is a primitive-style container. A static bits conversion helper would keep these methods allocation-free. |
||
| ensureCapacity(size + 1); | ||
| array[size++] = Float16.valueOf(value).toBits(); | ||
| modCount++; | ||
| return true; | ||
| } | ||
|
|
||
| public float getFloat(int index) { | ||
| checkIndex(index); | ||
| return Float16.fromBits(array[index]).toFloat(); | ||
| } | ||
|
|
||
| public short getShort(int index) { | ||
| checkIndex(index); | ||
| return array[index]; | ||
| } | ||
|
|
||
| public boolean hasArray() { | ||
| return array != null; | ||
| } | ||
|
|
||
| public short[] getArray() { | ||
| return array; | ||
| } | ||
|
|
||
| public short[] copyArray() { | ||
| return Arrays.copyOf(array, size); | ||
| } | ||
|
|
||
| private void ensureCapacity(int minCapacity) { | ||
| if (array.length >= minCapacity) { | ||
| return; | ||
| } | ||
| int newCapacity = array.length + (array.length >> 1) + 1; | ||
| if (newCapacity < minCapacity) { | ||
| newCapacity = minCapacity; | ||
| } | ||
| array = Arrays.copyOf(array, newCapacity); | ||
| } | ||
|
|
||
| private void checkIndex(int index) { | ||
| if (index < 0 || index >= size) { | ||
| throw new IndexOutOfBoundsException("Index: " + index + ", Size: " + size); | ||
| } | ||
| } | ||
|
|
||
| private void checkPositionIndex(int index) { | ||
| if (index < 0 || index > size) { | ||
| throw new IndexOutOfBoundsException("Index: " + index + ", Size: " + size); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated equals/hashCode for float16 now use numeric semantics, but Float16.equals/hashCode are bitwise.
With this change, +0 and -0 compare equal in generated messages, and NaN is not equal to NaN, while Float16 itself uses raw-bit equality. That mismatch is surprising in user code. Can we align generated message behavior with Float16.equals/hashCode (or make the rule explicit and consistent across runtimes)?