Conversation
Release consumed ScanKv responses and hand unconsumed responses to close callbacks. Release close-scanner acknowledgements and preserve late-response delivery. Add ByteBuf ownership regression tests for consumption, errors, and scanner closure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #4363
Fix network buffer leaks in no-limit primary-key batch scans, including when results are fully consumed and the scanner is closed normally.
Related to #3003, which addresses
LimitBatchScanner.Brief change log
ScanKvResponsebuffers infinally, covering data, empty, error, and parsing-failure paths.getRecords()copies the data, so returned rows remain valid after the response buffer is released.Tests
Added regression coverage using real serialized and parsed responses, with explicit reference-count assertions, row reads after buffer release, and exactly-once release verification.
The four minimal reproductions fail before the fix (
refCnt == 1) and pass afterward (refCnt == 0).Passed locally:
KvBatchScannerTest: 28 tests.CompositeBatchScannerTest: 5 tests.KvSnapshotAndLogBatchScannerTest: 1 test.TableKvScanITCase: 9 tests.The full repository suite was not run. Other previously observed CI leak warnings have not been individually attributed.
API and Format
No public API or storage-format changes.
Documentation
No user-facing documentation changes required.
Generative AI disclosure
AI-assisted implementation and review using Codex, Claude, and GLM.