[server] Fix spurious ISR shrink after leader election#3702
Open
fxbing wants to merge 1 commit into
Open
Conversation
Preserve follower fetch state across repeated leader notifications and reset follower state only when the leader epoch advances. Fixes apache#3698.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3698
A newly elected leader may remove healthy followers from ISR immediately after the first write because their newly created
FollowerReplicastate does not receive the normal lag grace period.A repeated
NotifyLeaderAndIsrrequest can also replace existingFollowerReplicaobjects and discard their fetch offsets and caught-up timestamps, causing the same spurious ISR shrink.Brief change log
FollowerReplicaobjects for unchanged assignments.Tests
AdjustIsrTest#testShrinkIsrAdjustIsrTest#testDoNotShrinkIsrAfterRepeatedNotifyLeaderAndIsrAdjustIsrTest#testPreserveFollowerStateOnLeaderReelectionAdjustIsrTest,FollowerReplicaTest, andReplicaTest: 25 tests passed.API and Format
No public API, configuration, metric, RPC, or storage-format changes.
Documentation
No documentation changes. This is an internal replica lifecycle bug fix.
Generative AI disclosure
Yes. Generated with OpenAI Codex and reviewed by the human developer.