[hotfix] Fix flaky TableChangeWatcherTest by awaiting CuratorCache init#2936
Open
platinumhamburg wants to merge 1 commit intoapache:mainfrom
Open
[hotfix] Fix flaky TableChangeWatcherTest by awaiting CuratorCache init#2936platinumhamburg wants to merge 1 commit intoapache:mainfrom
platinumhamburg wants to merge 1 commit intoapache:mainfrom
Conversation
TableChangeWatcherTest.testSchemaChanges intermittently fails because tables are created before CuratorCache completes its initial sync. During initial sync, NODE_CHANGED events from the tree scan can race with table creation, causing processCreateTable() to observe incomplete ZK state and silently drop the CreateTableEvent. Add awaitInitialized() to TableChangeWatcher using CuratorCacheListener .initialized() callback, and wait for it in beforeEach before creating tables. Clear any stale events from initial sync afterward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TableChangeWatcherTest.testSchemaChanges intermittently fails because tables are created before CuratorCache completes its initial sync. During initial sync, NODE_CHANGED events from the tree scan can race with table creation, causing processCreateTable() to observe incomplete ZK state and silently drop the CreateTableEvent.
Add awaitInitialized() to TableChangeWatcher using CuratorCacheListener .initialized() callback, and wait for it in beforeEach before creating tables. Clear any stale events from initial sync afterward.
Purpose
Linked issue: close #2935 2935
Brief change log
Tests
API and Format
Documentation