Skip to content

[FLINK-40704][build] Enable spotless for java 25 - #29232

Merged
snuyanzin merged 1 commit into
apache:masterfrom
snuyanzin:flink40704
Sep 18, 2026
Merged

snuyanzin merged 1 commit into
apache:masterfrom
snuyanzin:flink40704

Conversation

@snuyanzin

@snuyanzin snuyanzin commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

What is the purpose of the change

The PR enables spotless for java 25 and sets different version of aosp depending on java version

aosp is the main issue:
1.24.0 - the latest still supporting jdk11
1.28.0 - the latest still supporting jdk17
1.30.0 - the min supporting jdk25

so PR makes this depending on java version
luckily result of formatting is same

Brief change log

pom

Verifying this change

run on different java versions

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( yes)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Tool Name and Version]

@flinkbot

flinkbot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@spuru9

spuru9 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

The PR mentions no dependency changes. Can you fix that. Thanks.

@snuyanzin

Copy link
Copy Markdown
Contributor Author

makes sense, updated

@spuru9 spuru9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label Sep 18, 2026
@snuyanzin
snuyanzin merged commit ae019ca into apache:master Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants