[FLINK-40662][tests] Fail fast when the S3 test container does not start - #29222
Open
MartijnVisser wants to merge 2 commits into
Open
MartijnVisser wants to merge 2 commits into
MartijnVisser wants to merge 2 commits into
Conversation
`export VAR=$(docker run ...)` reports the exit code of export, and the readiness loop compared with `-ne`, which is arithmetic, so a failed image pull left S3_ENDPOINT as the bare string `http://`. * Keep the `docker run` exit code and retry the start three times * Add `wait_for_container_running` to `common.sh`, used here and by `aws_cli_start` * Reject an endpoint without a port binding and bound the readiness wait Generated-by: Claude Code (Claude Opus 5)
A failed openSession yielded the string "null" and the test carried on, sending every request to /sessions/null/... The handle is now checked the way execute_statement already checks the operation handle. Generated-by: Claude Code (Claude Opus 5)
Collaborator
spuru9
reviewed
Sep 17, 2026
| if [[ "$(docker inspect -f '{{.State.Running}}' "${container_id}" 2>/dev/null)" == "true" ]]; then | ||
| return 0 | ||
| fi | ||
| sleep 0.1 |
Contributor
There was a problem hiding this comment.
optional qq: though not a issue in happy scenario, isnt 0.1s a little too less of sleep? Maybe 1s.
spuru9
approved these changes
Sep 17, 2026
github-actions
Bot
added
the
community-reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
s3_startmissed thedocker runexit code and never waited for the container, so a failed imagepull left
S3_ENDPOINTas the bare stringhttp://and 'Run kubernetes Materialized Table test'failed with a null session handle.
Brief change log
s3_startkeeps thedocker runexit code, retries three times, aborts if the container does notcome up, and rejects an endpoint without a port binding
wait_for_container_runningincommon.sh, used bys3_startandaws_cli_starttest_kubernetes_materialized_table.shrejects an empty ornullsession handleVerifying this change
This change added tests and can be verified as follows:
s3_startagainst adockerstub reproducing the failed pulls of azure 79037 and 79076: 12 of 12red on 2440f65, 4 of 4 green after
/healthz, a missing image tag aborts--vm-driver=noneand does not run on macOSDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 5)