[FLINK-40693][table] Align floating-point IN predicates with equality for signed zero - #29221
Open
ParyshevSergey wants to merge 1 commit into
Open
ParyshevSergey wants to merge 1 commit into
ParyshevSergey wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
FLOAT/DOUBLE equality accepts opposite signed zeros, but constant-list IN/NOT IN implemented through SEARCH can reject them because the underlying hash sets use boxed equality. For example, typed runtime rows with IDs [1, 1, 2] and
values [-0.0, -0.0, +0.0] produce [2] for IN (0, 2), while equality produces [1, 1, 2].
This change makes floating-point SEARCH membership consistent with existing numeric equality for signed zero.
Brief change log
The general hash-set contracts, generated per-row lookup and NULL handling remain unchanged. Existing NaN behavior is preserved.
Verifying this change
Tests used the freshly built runtime artifact. Full CI and release-branch backports were not run.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (model: GPT-6 Astra; client version not exposed)