[FLINK-40230][table] StringToBinary and RawToBinary cast rules might generate runtime code with useless array copy#28814
Open
snuyanzin wants to merge 1 commit into
Open
[FLINK-40230][table] StringToBinary and RawToBinary cast rules might generate runtime code with useless array copy#28814snuyanzin wants to merge 1 commit into
StringToBinary and RawToBinary cast rules might generate runtime code with useless array copy#28814snuyanzin wants to merge 1 commit into
Conversation
…ght generate runtime code with useless array copy
Collaborator
raminqaf
reviewed
Jul 24, 2026
raminqaf
left a comment
raminqaf
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this fix! Left some comments
| } | ||
| }, | ||
| arrayLength(byteArrayTerm) | ||
| + (couldPad ? " == " : " <= ") |
Contributor
There was a problem hiding this comment.
Should we find a common class for this logic?
couldPad ? " == " : " <= "
Contributor
There was a problem hiding this comment.
Can we add some tests in CastRulesTest?
Contributor
Author
There was a problem hiding this comment.
It is already covered by tens of tests exactly for these rules
| .toString(); | ||
| } else { | ||
| final int targetLength = LogicalTypeChecks.getLength(targetLogicalType); | ||
| final boolean couldPad = couldPad(targetLogicalType, targetLength); |
Contributor
There was a problem hiding this comment.
I think we can move the computation of couldPad lower in the condition
github-actions
Bot
added
the
community-reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In case of same size it generates code to copy array while in fact there is no need for that
The PR makes the generation more optimal
Brief change log
rules
Verifying this change
existing cast tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?