[FLINK-40168][table] Thread the EARLY_FIRE hint into the interval join#28796
Open
weiqingy wants to merge 1 commit into
Open
[FLINK-40168][table] Thread the EARLY_FIRE hint into the interval join#28796weiqingy wants to merge 1 commit into
weiqingy wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @RocMarshal, opening PR-1b of the FLIP-497 stack ahead as a draft. It's stacked on #28353, so I'll rebase it onto master and take it out of draft for review once #28353 is merged. Thanks! |
weiqingy
force-pushed
the
FLINK-36953-pr1b-thread
branch
2 times, most recently
from
July 22, 2026 05:10
96ba48f to
647116f
Compare
weiqingy
force-pushed
the
FLINK-36953-pr1b-thread
branch
from
July 25, 2026 02:10
647116f to
a856401
Compare
weiqingy
marked this pull request as ready for review
July 25, 2026 02:15
Contributor
Author
|
Hi @RocMarshal, #28353 (PR-1a) has merged, so I've rebased this onto master. The diff is now standalone: just the planner threading and its tests. Taking it out of draft. Ready for review when you have a chance, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the FLIP-497 implementation stack under umbrella FLINK-36953. Landing order:
targetoptionWhat is the purpose of the change
Threads the (already-registered)
EARLY_FIREhint through the planner to the ExecNode.StreamPhysicalIntervalJoinRulereads the hint, resolves the effective time mode from the join's time domain, validates the domain combinations, and threads the delay and time mode intoStreamExecIntervalJoinas NON_NULL JSON fields. The operator receives the parameters but ignores them; runtime behavior lands in PR-4.Brief change log
StreamPhysicalIntervalJoinRulereads the hint, resolves the effective time mode, rejects row-time triggering on a processing-time join, and rejects (for now) processing-time triggering on an event-time join.earlyFireDelay/earlyFireTimeModethroughStreamPhysicalIntervalJoinintoStreamExecIntervalJoinas NON_NULL JSON fields.Verifying this change
This change added tests and can be verified as follows:
EarlyFireJoinHintTest:earlyFireDelay/earlyFireTimeModereach the exec plan for both a row-time (defaultROWTIME) and a processing-time (defaultPROCTIME) interval join; row-time-on-proctime and processing-time-on-rowtime are rejected; a compiled-plan JSON round-trip covers serialization of the new ExecNode fields.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Anthropic)