[FLINK-39034][streaming] Fix timestamp loss in SortPartitionOperator#28210
Open
Jackeyzhe wants to merge 1 commit into
Open
[FLINK-39034][streaming] Fix timestamp loss in SortPartitionOperator#28210Jackeyzhe wants to merge 1 commit into
Jackeyzhe wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes the timestamp loss issue in
SortPartitionOperatorwhen running in STREAMING mode.When users use
fullWindowPartition().sortPartition()operator combination in Flink DataStream API, the timestamp was being lost duringSortPartitionOperatorprocessing, causingctx.timestamp()in downstreamKeyedProcessFunctionto returnnull.Brief change log
Modified
SortPartitionOperator.java, add timestamp in sorter and set in streamrecord when collecting outputVerifying this change
fix unit test in SortPartitionOperatorTest.java
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?