[FLINK-36736][table] Fix target columns for row-level updates#28198
Draft
Au-Miner wants to merge 2 commits into
Draft
[FLINK-36736][table] Fix target columns for row-level updates#28198Au-Miner wants to merge 2 commits into
Au-Miner wants to merge 2 commits into
Conversation
…al required columns for row-level update
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix
DynamicTableSink.Context#getTargetColumnsfor row-level UPDATE so it contains all columns delivered to the sink, instead of only the columns from the SET clause.Due to the dependency on the pre-PR FLINK-36735, it is set to draft PR.
Brief change log
DynamicSinkUtils#convertSinkToRelto apply target columns after the UPDATE rewrite, using the required physical columns returned byconvertUpdate.TestUpdateDeleteTableFactoryfor both sink ability application and runtime sink context.Verifying this change
Updated
RowLevelUpdateTestplan expectations andUpdateTableITCaseassertions to verify full-row, partial required-column, and disjoint required/updated-column UPDATE cases expose the correct target columns.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation