Skip to content

[FLINK-38192][table] Improve DynamicSourceUtils exception message#28195

Open
arvindKandpal-ksolves wants to merge 1 commit into
apache:masterfrom
arvindKandpal-ksolves:FLINK-38192
Open

[FLINK-38192][table] Improve DynamicSourceUtils exception message#28195
arvindKandpal-ksolves wants to merge 1 commit into
apache:masterfrom
arvindKandpal-ksolves:FLINK-38192

Conversation

@arvindKandpal-ksolves
Copy link
Copy Markdown

What is the purpose of the change

This pull request resolves FLINK-38192.
It improves the exception message in DynamicSourceUtils.validateAndApplyMetadata when a DynamicTableSource does not implement the SupportsReadingMetadata interface. Previously, the error message hardcoded the string "DynamicTableSource", which made it difficult to identify the actual source causing the issue. This change ensures that the actual runtime class name of the table source is printed, providing more context to users for debugging.

Brief change log

  • Updated the exception string formatting in DynamicSourceUtils.java to use source.getClass().getName() instead of DynamicTableSource.class.getSimpleName().
  • Replaced source.asSummaryString() with tableDebugName to correctly display the actual table name in the error message.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage. Existing tests in the flink-table-planner module have been executed locally (mvn clean test -pl flink-table/flink-table-planner) and they pass successfully.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 19, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants