[FLINK-38192][table] Improve DynamicSourceUtils exception message#28195
Open
arvindKandpal-ksolves wants to merge 1 commit into
Open
[FLINK-38192][table] Improve DynamicSourceUtils exception message#28195arvindKandpal-ksolves wants to merge 1 commit into
arvindKandpal-ksolves wants to merge 1 commit into
Conversation
Collaborator
autophagy
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request resolves FLINK-38192.
It improves the exception message in
DynamicSourceUtils.validateAndApplyMetadatawhen aDynamicTableSourcedoes not implement theSupportsReadingMetadatainterface. Previously, the error message hardcoded the string "DynamicTableSource", which made it difficult to identify the actual source causing the issue. This change ensures that the actual runtime class name of the table source is printed, providing more context to users for debugging.Brief change log
DynamicSourceUtils.javato usesource.getClass().getName()instead ofDynamicTableSource.class.getSimpleName().source.asSummaryString()withtableDebugNameto correctly display the actual table name in the error message.Verifying this change
This change is a trivial rework / code cleanup without any test coverage. Existing tests in the
flink-table-plannermodule have been executed locally (mvn clean test -pl flink-table/flink-table-planner) and they pass successfully.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation