[FLINK-39701][s3]Fix Concurrency Annotation in native-s3-fs#28190
Open
Samrat002 wants to merge 1 commit into
Open
[FLINK-39701][s3]Fix Concurrency Annotation in native-s3-fs#28190Samrat002 wants to merge 1 commit into
Samrat002 wants to merge 1 commit into
Conversation
Collaborator
Samrat002
commented
May 18, 2026
Comment on lines
+303
to
+304
| @Nullable private volatile Configuration flinkConfig; | ||
| @Nullable private volatile BucketConfigProvider bucketConfigProvider; |
Contributor
Author
There was a problem hiding this comment.
Without volatile, the JVM can legally:
- Cache flinkConfig in a CPU register on thread B's core
- Never re-read it from main memory
- Thread B sees null even though thread A wrote a real Configuration
Contributor
Author
|
@gaborgsomogyi PTAL |
Samrat002
commented
May 19, 2026
| import javax.annotation.concurrent.ThreadSafe; | ||
|
|
||
| @Internal | ||
| @ThreadSafe |
Contributor
Author
There was a problem hiding this comment.
@gaborgsomogyi :
if we say thread safe , from what thread we are protecting against ?
if not then we dont care .
If there are multiple thread involved. list them !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR adds missing thread-safety annotations across flink-s3-fs-native to aid future maintainability.
Brief change log
happens-before guarantee. Added volatile to both fields and stashed bucketConfigProvider into a local variable before use (prevents a TOCTOU race between the null-check and
dereference on a volatile read).
lock. All reads and writes of closed are already inside the ReentrantLock, so volatile was misleading and unnecessary. Removed volatile.
Annotation hygiene:
NativeS3RecoverableWriter, NativeS3ObjectOperations, NativeS3Committer, NativeS3DelegationTokenReceiver, NativeS3DelegationTokenProvider,
DynamicTemporaryAWSCredentialsProvider
Verifying this change
Existing UT and e2e test over the large cluster
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?