[hotfix][table-runtime] Fix typo in RowTimeMiniBatchAssignerOperator class name#28172
Conversation
raminqaf
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
davidradl
left a comment
There was a problem hiding this comment.
This is a change to the API - can see this in the java docs https://nightlies.apache.org/flink/flink-docs-stable/api/java/overview-tree.html
I suggest you deprecate the existing one and introduce the newly correctly named one. Then there will be no migration impact.
Thanks for taking a look! I don't think this operator is part of the public API surface, though:
Given that, a typo fix via rename should be safe and keeping a deprecated misspelled shim would just be carrying a misleading class name forward. Please let me know if I'm missing something. |
What is the purpose of the change
This pull request fixes a typo in the class name
RowTimeMiniBatchAssginerOperator. The class is renamed toRowTimeMiniBatchAssignerOperator(and the corresponding test class toRowTimeMiniBatchAssignerOperatorTest), matching the spelling already used by its siblingProcTimeMiniBatchAssignerOperatorand the surrounding packagewmassigners.The class is
@Internal(it is an implementation-side stream operator with no stability annotation, instantiated only by the table planner) and holds no operator/keyed state, so the rename is safe to do directly.Brief change log
RowTimeMiniBatchAssginerOperator→RowTimeMiniBatchAssignerOperator(file, class, and constructor) inflink-table-runtime.RowTimeMiniBatchAssginerOperatorTest→RowTimeMiniBatchAssignerOperatorTest.StreamExecMiniBatchAssigner(flink-table-planner) and the{@link ...}reference in the javadoc ofProcTimeMiniBatchAssignerOperator.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
The existing tests in
RowTimeMiniBatchAssignerOperatorTestcontinue to pass under the renamed class:Does this pull request potentially affect one of the following parts:
@Public(Evolving): no (the class is internal; it has no stability annotation and is only instantiated fromStreamExecMiniBatchAssigner)transientruntime fields and a final config value, no operator/keyed state)Documentation
Was generative AI tooling used to co-author this PR?