[FLINK-39331] Add @Experimental annotation to public Native S3 classes#27833
[FLINK-39331] Add @Experimental annotation to public Native S3 classes#27833Samrat002 wants to merge 2 commits intoapache:masterfrom
Conversation
Izeren
left a comment
There was a problem hiding this comment.
Thank you for the PR @Samrat002, I wonder if we should rather reduce visibility of the classes than adding experimental annotation to them (except for factories)
.../flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/writer/NativeS3Committer.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/flink/fs/s3native/writer/NativeS3RecoverableFsDataOutputStream.java
Outdated
Show resolved
Hide resolved
...tems/flink-s3-fs-native/src/main/java/org/apache/flink/fs/s3native/NativeS3OutputStream.java
Outdated
Show resolved
Hide resolved
|
@Samrat002, In addition, should we downgrade: Also, NativeS3RecoverableWriter is marked as @PublicEvolving, and it should be Experimental@ as well |
Yes . right thing to do and reduce the API visiblity . i have made the classes
yes. my miss. fixed it now |
What is the purpose of the change
Mark the public API classes in flink-s3-fs-native as experimental to signal to users that this feature is still evolving and may undergo changes in future releases.
Brief change log
Mark following public class with
@ExperimentalNativeS3FileSystemFactoryNativeS3AFileSystemFactoryNativeS3OutputStreamNativeS3RecoverableFsDataOutputStreamNativeS3CommitterVerifying this change
Existing UT suffices.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yes (marked as@Experimental)Documentation