Skip to content

FINERACT-2455: Fix WorkingCapitalPeriodPaymentRate.feature long cob runs, attempt to fix flaky CobPartitioningTest - #6479

Open
Cocoa-Puffs wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455-optimize-e2e-execution-times-of-WorkingCapitalPeriodPaymentRate.feature
Open

Cocoa-Puffs wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2455-optimize-e2e-execution-times-of-WorkingCapitalPeriodPaymentRate.feature

Conversation

@Cocoa-Puffs

Copy link
Copy Markdown
Contributor

Description

CobPartitioningTest.testLoanCOBPartitioningQuery() frequently fails in Github Actions runs with:

Exception Description: Syntax error parsing [SELECT lt.typeOf AS transactionType, ... ]. The select item is missing from the result variable declaration. SELECT lt.typeOf [ AS transactionType ] ... The SELECT clause has 'lt.typeOf' and 'AS transactionType' that are not separated by a comma.

The culprit is the query: findTransactionDataForForeclosureIncome() in LoanTransactionRepository. It uses "AS " in the select clause which are in practice JPQL result-variables. The parse error is EclipseLink's Hermes parser reporting that the grammar singleton it consulted has no result-variable rule registered, likely because another thread is still initializing it. My proposed fix is to bypass result-variables by using a constructor expression, that every other query uses too.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

Your assigned reviewer(s) will follow our guidelines for code reviews.

…uns, attempt to fix flaky CobPartitioningTest
@Cocoa-Puffs
Cocoa-Puffs force-pushed the FINERACT-2455-optimize-e2e-execution-times-of-WorkingCapitalPeriodPaymentRate.feature branch from ddbcef7 to 3d46c6a Compare September 18, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant