Skip to content

FINERACT-2843: Resurrect Fineract client and avro schema publishing - #6472

Open
adamsaghy wants to merge 1 commit into
apache:developfrom
adamsaghy:FINERACT-2843
Open

FINERACT-2843: Resurrect Fineract client and avro schema publishing#6472
adamsaghy wants to merge 1 commit into
apache:developfrom
adamsaghy:FINERACT-2843

Conversation

@adamsaghy

@adamsaghy adamsaghy commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

Your assigned reviewer(s) will follow our guidelines for code reviews.

IOhacker
IOhacker requested changes Sep 17, 2026
View reviewed changes
Comment thread build.gradle
[
'fineract-avro-schemas',
'fineract-client',
'fineract-client-feign',

@IOhacker IOhacker Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamsaghy they are required to be published independently in order to be imported in projects. The fineract-client-feign brings everything, and we build more lighter apps. I will ask to keep all the libraries published + the fineract-client-feign

@adamsaghy adamsaghy Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IOhacker I am not sure i follow you on this one.

The built fineract-client / fineract-client-feign / fineract-avro-schemas are not depending on anything but its own files.

I see no reason to publish all fineract modules since it is not designed to be used as dependencies in any project, but their sole purpose to be modularized internally.

Any project who is intended to communicate with Fineract via fineract-client-feign, just add it as a jar dependency and use it. They dont need any of the other modules or anything further.

@IOhacker

IOhacker commented Sep 17, 2026 via email

Copy link
Copy Markdown
Contributor

@adamsaghy

adamsaghy commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

We use them independently :) El jue, 17 sept 2026 a las 12:20, Adam Saghy @.>) escribió:
…
@.* commented on this pull request. ------------------------------ In build.gradle <#6472 (comment)>: > @@ -62,29 +62,7 @@ buildscript { [ 'fineract-avro-schemas', 'fineract-client', - 'fineract-client-feign', @IOhacker https://github.com/IOhacker I am not sure i follow you on this one. The built fineract-client / fineract-client-feign / fineract-avro-schemas are not depending on anything but its own files. I see no reason to publish all fineract modules since it is not designed to be used as dependencies in any project, but their sole purpose to be modularized internally. — Reply to this email directly, view it on GitHub <#6472?email_source=notifications&email_token=ALD2ZAQB37O2AVZI55RTDFT5PQTOHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRTHE3TGMZVGU22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#discussion_r4040096683>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALD2ZATONHRRGLUFS2LHBZL5PQTOHAVCNFSNUABEKJSXA33TNF2G64TZHM2DQNBRHA2TSOJ3JFZXG5LFHM2TIOJQHAYTMMJZHCQXMAQ . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS https://github.com/notifications/mobile/ios/ALD2ZATL6GCUS6HPPKZU2ED5PQTOHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRTHE3TGMZVGU22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y and Android https://github.com/notifications/mobile/android/ALD2ZASUNEHOX3ALFPBWDHT5PQTOHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRTHE3TGMZVGU22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI. Download it today! You are receiving this because you were mentioned.Message ID: </pull/6472/review/5239733555 @.*** com>

Considering we did not published into Apache Nexus for years, you might do it somewhere else...

@IOhacker

IOhacker commented Sep 17, 2026 via email

Copy link
Copy Markdown
Contributor

@adamsaghy

adamsaghy commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Right, but it is using the same build script that publish to a generic maven repository El jue, 17 sept 2026 a las 12:30, Adam Saghy @.>) escribió:
…
adamsaghy left a comment (apache/fineract#6472) <#6472 (comment)> We use them independently :) El jue, 17 sept 2026 a las 12:20, Adam Saghy @. >) escribió: … <#m_-3877515996741756696_> @. commented on this pull request. ------------------------------ In build.gradle <#6472 (comment) <#6472 (comment)>>: > @@ -62,29 +62,7 @@ buildscript { [ 'fineract-avro-schemas', 'fineract-client', - 'fineract-client-feign', @IOhacker https://github.com/IOhacker https://github.com/IOhacker I am not sure i follow you on this one. The built fineract-client / fineract-client-feign / fineract-avro-schemas are not depending on anything but its own files. I see no reason to publish all fineract modules since it is not designed to be used as dependencies in any project, but their sole purpose to be modularized internally. — Reply to this email directly, view it on GitHub < #6472 <#6472>?email_source=notifications&email_token=ALD2ZAQB37O2AVZI55RTDFT5PQTOHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRTHE3TGMZVGU22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#discussion_r4040096683>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALD2ZATONHRRGLUFS2LHBZL5PQTOHAVCNFSNUABEKJSXA33TNF2G64TZHM2DQNBRHA2TSOJ3JFZXG5LFHM2TIOJQHAYTMMJZHCQXMAQ . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS https://github.com/notifications/mobile/ios/ALD2ZATL6GCUS6HPPKZU2ED5PQTOHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRTHE3TGMZVGU22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y and Android https://github.com/notifications/mobile/android/ALD2ZASUNEHOX3ALFPBWDHT5PQTOHA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMRTHE3TGMZVGU22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI. Download it today! You are receiving this because you were mentioned.Message ID: </pull/6472 <#6472>/review/5239733555 <(523)%20973-3555> @.* com> Considering we did not published into Apache Nexus for years, you might do it somewhere else... — Reply to this email directly, view it on GitHub <#6472?email_source=notifications&email_token=ALD2ZAST2KU67CWFKLIPQAD5PQUVFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZRHEZTEOBRGAY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5719328101>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALD2ZATQNBNFDUEBR7XFQA35PQUVFAVCNFSNUABEKJSXA33TNF2G64TZHM2DQNBRHA2TSOJ3JFZXG5LFHM2TIOJQHAYTMMJZHCQXMAQ . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS https://github.com/notifications/mobile/ios/ALD2ZAQOQ3DBLVUUMLRTMLD5PQUVFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZRHEZTEOBRGAY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y and Android https://github.com/notifications/mobile/android/ALD2ZAU4CKUTG35CRBCZQXT5PQUVFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZRHEZTEOBRGAY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI. Download it today! You are receiving this because you were mentioned.Message ID: @.***>

No, its not.

Openmf versioning and publish scripts are different (custom solution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IOhacker IOhacker IOhacker approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamsaghy @IOhacker