Conversation
isCI was derived from JENKINS_URL, which GitHub Actions never sets, so it was always false and uploadInBackground stayed enabled on CI. Background upload on an ephemeral runner can lose a Build Scan when the job ends before the upload completes. Key the check to GITHUB_ACTIONS instead. Also update the Develocity Gradle plugin from 4.5.0 to 4.5.1. The Common Custom User Data Gradle plugin is already on the latest version, 2.8.0. Assisted-By: claude-code-opus-5
Member
|
Fineract Signed Commits Check / Verify Commit Signatures (pull_request) I think we can ignore this as it is commit is already signed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves FINERACT-2840.
settings.gradlederivedisCIfrom theJENKINS_URLenvironment variable. Fineract's CI runs entirely on GitHub Actions, which never setsJENKINS_URL, and there is no Jenkins configuration anywhere in the repository — soisCIwas alwaysfalse.Its only consumer is
buildScan.uploadInBackground = !isCI, which meant background upload stayed enabled on CI. On an ephemeral GitHub Actions runner the job can terminate before a backgrounded Build Scan upload completes, losing the scan.This keys the check to
GITHUB_ACTIONS, which GitHub Actions always sets. Build Scan uploads are now synchronous on CI, and remain backgrounded for local developer builds where the added latency would be noticeable.Also updates the Develocity Gradle plugin from 4.5.0 to 4.5.1.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.