FINERACT-2684: Decouple transient collaborators from the SavingsAccount entity - #6201
Open
alberto-art3ch wants to merge 1 commit into
Open
Conversation
alberto-art3ch
force-pushed
the
FINERACT-2421/savings-account-remove-transient-elements
branch
2 times, most recently
from
July 29, 2026 17:53
47e9f12 to
28f6df3
Compare
alberto-art3ch
force-pushed
the
FINERACT-2421/savings-account-remove-transient-elements
branch
from
July 29, 2026 19:51
28f6df3 to
d7ebb5e
Compare
adamsaghy
marked this pull request as ready for review
July 29, 2026 22:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes runtime service collaborators that were stored as @Transient/transient fields on the SavingsAccount JPA entity and injected after hydration via setHelpers(...). This kept infrastructure/config dependencies out of the domain entity's state.
No functional/behavioral change — pure refactor to decouple transient elements from the persistent entity.
FINERACT-2684
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.