Skip to content

FINERACT-2719: Add submittedOnDateTime to journal entry responses - #6195

Draft
Samer-Melhem-FOO wants to merge 3 commits into
apache:developfrom
foodeveloper:port/CBS-121-journal-entry-submitted-datetime
Draft

FINERACT-2719: Add submittedOnDateTime to journal entry responses#6195
Samer-Melhem-FOO wants to merge 3 commits into
apache:developfrom
foodeveloper:port/CBS-121-journal-entry-submitted-datetime

Conversation

@Samer-Melhem-FOO

Copy link
Copy Markdown
Contributor

Description

The Journal Entries API only returns submittedOnDate (date-only), so any UI reading it always shows a time of 00:00:00, even though the journal entry's actual creation timestamp is stored in acc_gl_journal_entry.created_on_utc.

This adds a new optional submittedOnDateTime field to JournalEntryData (Fineract-style [year, month, day, hour, minute, second] array), sourced from created_on_utc in JournalEntryReadPlatformServiceImpl. submittedOnDate is left unchanged for backward compatibility.

JIRA: https://issues.apache.org/jira/browse/FINERACT-2719

Checklist

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Note: no existing unit/integration test covers JournalEntryReadPlatformServiceImpl's row-mapping logic (it's a plain JDBC RowMapper, not easily unit-testable in isolation), so none were added — happy to add integration-test coverage if a reviewer points to the right harness for it.

@Samer-Melhem-FOO
Samer-Melhem-FOO marked this pull request as draft July 28, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant