FINERACT-2719: Add submittedOnDateTime to journal entry responses - #6195
Draft
Samer-Melhem-FOO wants to merge 3 commits into
Draft
FINERACT-2719: Add submittedOnDateTime to journal entry responses#6195Samer-Melhem-FOO wants to merge 3 commits into
Samer-Melhem-FOO wants to merge 3 commits into
Conversation
Samer-Melhem-FOO
marked this pull request as draft
July 28, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Journal Entries API only returns
submittedOnDate(date-only), so any UI reading it always shows a time of00:00:00, even though the journal entry's actual creation timestamp is stored inacc_gl_journal_entry.created_on_utc.This adds a new optional
submittedOnDateTimefield toJournalEntryData(Fineract-style[year, month, day, hour, minute, second]array), sourced fromcreated_on_utcinJournalEntryReadPlatformServiceImpl.submittedOnDateis left unchanged for backward compatibility.JIRA: https://issues.apache.org/jira/browse/FINERACT-2719
Checklist
Note: no existing unit/integration test covers
JournalEntryReadPlatformServiceImpl's row-mapping logic (it's a plain JDBCRowMapper, not easily unit-testable in isolation), so none were added — happy to add integration-test coverage if a reviewer points to the right harness for it.