FINERACT-2718: Migrate group center tests to feign - #6194
Open
DeathGun44 wants to merge 6 commits into
Open
Conversation
…DTOs Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
DeathGun44
force-pushed
the
FINERACT-2718/migrate-group-center-tests-to-feign
branch
from
July 28, 2026 10:41
03827d9 to
293ee66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Migrates the group and center integration tests from the old REST-assured HTTP client to the typed Feign SDK client
Why
The old tests call the server with hand-written REST-assured requests and read untyped JSON. Moving them onto the generated Feign client gives typed requests and responses, so the tests are safer to change and consistent with the rest of the migrated suite.
What changed
Test classes migrated
CenterIntegrationTestGroupTestGroupLoanIntegrationTestNew typed helpers:
FeignGroupHelper,FeignCenterHelper,FeignStaffHelper,FeignGlimHelperRemoved the old stopgap:
FeignGroupCenterHelper(a raw-HTTP helper from an earlier PR) and repointed its two usersLoanReschedulingWithinCenterTestandExternalIdSupportIntegrationTest- at the new typed helpers.Production change (minimal, additive):
PostGroupsRequestandPostCentersRequestin the Swagger DTOs so groups and centers can be created through the typed model. These are additive only - the API wire format is unchanged.Where raw HTTP is still used (and why)
A few calls still go through
FeignRawHttpHelper(plainHttpURLConnection, not REST-assured) - only where the generated models genuinely can't express what the test asserts:active/clientMembersand center fields the response models don't expose,?command=...endpoints whose request models don't carry the command fields,Each is documented at the call site. No assertion was weakened and no REST-assured
was introduced.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.