FINERACT-2716: Log SMS campaign preview JSON parsing failure instead of silently swallowing it - #6190
Open
AshharAhmadKhan wants to merge 1 commit into
Conversation
…of silently swallowing it
Contributor
Author
|
hey @adamsaghy please trigger checks whenever possible, thanks! |
Contributor
Author
|
hey @adamsaghy , failures look flaky, can you please retrigger those checks? thanks a lot! |
Contributor
Author
|
Sorry for the ping @adamsaghy . I think this is ready for review ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
https://issues.apache.org/jira/browse/FINERACT-2716
Problem
The previewMessage-equivalent method in SmsCampaignWritePlatformServiceJpaImpl
caught IOException from JSON parsing and did nothing with it. No log, no
rethrow. The failure disappeared silently.
Fix
Replaced the // TODO throw something here with a log.error call. This was the
last remaining instance of this pattern in the class - every other
catch (IOException ...) block here already logs and continues.
This is a direct follow-up to FINERACT-2707, which fixed the equivalent issue
in EmailCampaignWritePlatformCommandHandlerImpl, and to the note left in that
PR flagging this exact method as the one remaining spot.
I also grepped the full codebase for "TODO throw something here" and for any
other silent catch (IOException e) {} blocks - this was the only remaining
occurrence; everything else already logs.
No functional change otherwise.