FINERACT-2715: Mark Activation Date as required in Client Entity import template - #6189
Open
Samer-Melhem-FOO wants to merge 1 commit into
Conversation
…rt template The Client Entity bulk import template did not visually indicate that Activation Date is required. ClientEntityImportHandler requires a valid Activation Date whenever the Active column is set to true, causing import failures on rows where the field was left blank despite the template giving no indication it was mandatory.
Contributor
Author
|
The only failing check here is This looks like a transient Docker Hub registry connectivity issue on the runner, unrelated to this PR's change (a single header-label fix in Could a maintainer re-run the failed job? I don't have the permissions to trigger a re-run myself. Thanks! |
IOhacker
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Client Entity bulk import template did not visually indicate that "Activation Date" is a required column.
ClientEntityImportHandlerrequires a valid Activation Date whenever the "Active" column is set totrue, so imports failed on rows left blank without any indication from the template that the field was mandatory.This changes the column header in
ClientEntityWorkbookPopulatorfrom"Activation Date "to"Activation Date* ", consistent with how other conditionally-required columns (e.g."Active*") are marked on the same sheet.JIRA
https://issues.apache.org/jira/browse/FINERACT-2715
Test plan
./gradlew :fineract-provider:compileJavapassesClientEntityWorkbookPopulatorTestdoes not hardcode it)