FINERACT-2714: Add ability to exclude closed clients from client search results - #6188
Conversation
IOhacker
left a comment
There was a problem hiding this comment.
@Samer-Melhem-FOO why no to exted to other client status?
|
Thanks for the review! The scope here is intentionally narrow: this maps to a single UI checkbox — "Exclude closed accounts" — on the client search screen, not a general-purpose client-status filter. The intent is just to let users hide closed clients from search results by default, since closed accounts otherwise clutter results for users who are typically looking for active/actionable clients. It isn't meant to generalize into filtering by arbitrary client status (pending, rejected, withdrawn, etc.) — that would be a bigger, separate feature with its own UI/UX (e.g. a status multi-select) and API design considerations, and isn't what this fix was scoped to solve. |
Description
The
POST /v2/clients/searchendpoint returns matching clients regardless of status, including closed ones, with no way for the caller to filter them out.This adds an optional
excludeClosedboolean field to theClientTextSearchsearch request. WhenexcludeClosed=true, the search excludes clients whose status isCLOSED(via astatus != CLOSEDpredicate inSearchingClientRepositoryImpl). When omitted orfalse, behavior is unchanged — fully backward compatible for existing callers.https://issues.apache.org/jira/browse/FINERACT-2714
Checklist