FINERACT-2713: Bind untyped report parameters numerically so Postgres cascades work - #6185
Open
oluexpert99 wants to merge 1 commit into
Open
FINERACT-2713: Bind untyped report parameters numerically so Postgres cascades work#6185oluexpert99 wants to merge 1 commit into
oluexpert99 wants to merge 1 commit into
Conversation
… cascades work
- Since FINERACT-2624 switched report-parameter substitution from string interpolation to
JDBC bind variables, a placeholder that appears in a report's SQL but is not one of that
report's own declared parameters binds as a String. On PostgreSQL, comparing a bigint
column to a bound character varying raises "operator does not exist: bigint = character
varying" and the query fails with HTTP 403; MySQL and MariaDB coerce the types silently,
which is why CI does not see it.
- The stock loanOfficerIdSelectAll option lookup is the clearest case. Its SQL filters
"... and o.id = ${officeId}", where officeId is supplied by the parent parameter, so
ReadReportingServiceImpl.getSQLtoRun loads the format types of loanOfficerIdSelectAll,
finds no entry for officeId, and castParamValue falls through to returning the raw
String. Every report whose Loan Officer dropdown cascades off office is therefore empty
on a PostgreSQL deployment.
- When no format type is declared, infer a numeric bind for a plain integer value so
strict engines compare correctly. The inference is deliberately narrow: the value must
match -?(0|[1-9]\d*), so currency codes, free text and identifiers carrying leading
zeros such as 000123 keep their String binding and are not mangled into numbers.
Declared NUMBER, INTEGER and DATE types are untouched.
- Add ReadReportingServiceImplTest, which captures the values bound for a report whose SQL
cascades on ${officeId}: an untyped "1" must arrive as a Long, while "USD" and "000123"
must stay Strings and a declared number type must keep working. The first case fails on
the unfixed code with "expected: java.lang.Long<1> but was: java.lang.String<1>"; the
other three assert the narrowness of the inference and hold either way by design.
Signed-off-by: oluexpert99 <farooq@techservicehub.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.