FINERACT-2710: Fix NPE downloading the recurring-deposit template without a term type - #6182
Open
oluexpert99 wants to merge 1 commit into
Open
FINERACT-2710: Fix NPE downloading the recurring-deposit template without a term type#6182oluexpert99 wants to merge 1 commit into
oluexpert99 wants to merge 1 commit into
Conversation
…hout a term type - GET /v1/recurringdepositaccounts/downloadtemplate returned HTTP 500 on any tenant holding a recurring-deposit product with no minimum-deposit-term type: RecurringDepositProductSheetPopulator.populate writes the min-deposit-term-type cell through an unguarded product.getMinDepositTermType().getValue(), so a null term type throws and the whole template download fails. The template is unusable for the entire tenant and there is no API-side workaround. - The field is optional on the product, and every sibling optional field in the same loop (min/max deposit amount, min/max deposit term, lock-in period, pre-closure penal interest) is already null-guarded. The fixed-deposit product sheet populator guards the equivalent field too, so this is an inconsistency between two sibling populators rather than a deliberate requirement. - Guard the write like its siblings: a product without a minimum-deposit-term type leaves that lookup cell blank instead of failing the download. Nothing changes for products that do carry one. - Add a unit test (RecurringDepositProductSheetPopulatorTest) covering a product whose term type is null: it fails on the unfixed code with the exact production NPE and asserts the product sheet is still written. Signed-off-by: oluexpert99 <farooq@techservicehub.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.