Skip to content

FINERACT-2710: Fix NPE downloading the recurring-deposit template without a term type - #6182

Open
oluexpert99 wants to merge 1 commit into
apache:developfrom
TECHSERVICES-LIMITED:bugfix/FINERACT-2710
Open

FINERACT-2710: Fix NPE downloading the recurring-deposit template without a term type#6182
oluexpert99 wants to merge 1 commit into
apache:developfrom
TECHSERVICES-LIMITED:bugfix/FINERACT-2710

Conversation

@oluexpert99

Copy link
Copy Markdown
Contributor
 - GET /v1/recurringdepositaccounts/downloadtemplate returned HTTP 500 on any tenant
    holding a recurring-deposit product with no minimum-deposit-term type:
    RecurringDepositProductSheetPopulator.populate writes the min-deposit-term-type cell
    through an unguarded product.getMinDepositTermType().getValue(), so a null term type
    throws and the whole template download fails. The template is unusable for the entire
    tenant and there is no API-side workaround.
  - The field is optional on the product, and every sibling optional field in the same loop
    (min/max deposit amount, min/max deposit term, lock-in period, pre-closure penal
    interest) is already null-guarded. The fixed-deposit product sheet populator guards the
    equivalent field too, so this is an inconsistency between two sibling populators rather
    than a deliberate requirement.
  - Guard the write like its siblings: a product without a minimum-deposit-term type leaves
    that lookup cell blank instead of failing the download. Nothing changes for products
    that do carry one.
  - Add a unit test (RecurringDepositProductSheetPopulatorTest) covering a product whose
    term type is null: it fails on the unfixed code with the exact production NPE and
    asserts the product sheet is still written.

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

Your assigned reviewer(s) will follow our guidelines for code reviews.

…hout a term type

- GET /v1/recurringdepositaccounts/downloadtemplate returned HTTP 500 on any tenant
  holding a recurring-deposit product with no minimum-deposit-term type:
  RecurringDepositProductSheetPopulator.populate writes the min-deposit-term-type cell
  through an unguarded product.getMinDepositTermType().getValue(), so a null term type
  throws and the whole template download fails. The template is unusable for the entire
  tenant and there is no API-side workaround.
- The field is optional on the product, and every sibling optional field in the same loop
  (min/max deposit amount, min/max deposit term, lock-in period, pre-closure penal
  interest) is already null-guarded. The fixed-deposit product sheet populator guards the
  equivalent field too, so this is an inconsistency between two sibling populators rather
  than a deliberate requirement.
- Guard the write like its siblings: a product without a minimum-deposit-term type leaves
  that lookup cell blank instead of failing the download. Nothing changes for products
  that do carry one.
- Add a unit test (RecurringDepositProductSheetPopulatorTest) covering a product whose
  term type is null: it fails on the unfixed code with the exact production NPE and
  asserts the product sheet is still written.

Signed-off-by: oluexpert99 <farooq@techservicehub.io>
@oluexpert99 oluexpert99 changed the title FINERACT-2710: Fix NPE downloading the recurring-deposit template without a term type FINERACT-2710: Fix NPE downloading the recurring-deposit template without a term type Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant