FINERACT-2709: Fix chart-of-accounts template guarding the wrong variable - #6181
Open
oluexpert99 wants to merge 1 commit into
Open
FINERACT-2709: Fix chart-of-accounts template guarding the wrong variable#6181oluexpert99 wants to merge 1 commit into
oluexpert99 wants to merge 1 commit into
Conversation
…able - ChartOfAccountsWorkbook.setNames builds a Tags named range per account type from the lookup-index entry, but null-checks the map it read the entry from rather than the entry itself: it reads Integer[] tagValueBeginEndIndexes from accountTypeToBeginEndIndexesofAccountNames, then tests the map for null and dereferences tagValueBeginEndIndexes[0] and [1] inside the block. - The map is an instance field that was already dereferenced on the line above (.get(i)), so it is never null at that point: the guard is always true and protects nothing, while reading as though it protects the array access. The value that can be null is the per-iteration array, from a Map.get miss. - The sibling block immediately below, which builds the AccountName named range, shows the intended pattern and guards the array it dereferences. The Tags block appears to be a copy of it with the guarded variable left unchanged. - Guard tagValueBeginEndIndexes instead, so a missing lookup-index entry skips the Tags named range rather than dereferencing null, matching the sibling block. - Note on reachability and on the test: with well-formed GL-account data the null branch cannot be reached. accountTypesNoDuplicatesList and the index map are both derived from the same glAccounts list, and setLookupTable only skips a put -- leaving a gap -- for an account type whose account-name list is empty, which cannot happen for a type that came from an actual account. This is therefore a dead guard and a latent NPE rather than a reproducible failure, and the added ChartOfAccountsWorkbookTest is a characterisation test: it pins the working path (one Tags_<type> range per account type, alongside the AccountName_<type> range) and would catch an incorrect fix, but it passes both with and without this change, since no input reachable through the public API can produce the null entry. Reaching the null branch would require reflecting into the populator's internal map, which would test implementation detail rather than behaviour. Signed-off-by: oluexpert99 <farooq@techservicehub.io>
Contributor
|
@oluexpert99 please check the failing log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.