Skip to content

FINERACT-405: Standardize mobile number validation across Client and … - #6177

Open
codigm wants to merge 2 commits into
apache:developfrom
codigm:FINERACT-405-standardize-mobile-number-validation
Open

FINERACT-405: Standardize mobile number validation across Client and …#6177
codigm wants to merge 2 commits into
apache:developfrom
codigm:FINERACT-405-standardize-mobile-number-validation

Conversation

@codigm

@codigm codigm commented Jul 25, 2026

Copy link
Copy Markdown

Description

Resolves FINERACT-405.

This PR standardizes mobile number validation across the Client and Staff modules.
Previously, the regular expression ^\+?[0-9]{7,15}$ was duplicated across three different files (ClientDataValidator, StaffCreateRequest, and StaffUpdateRequest).

This PR extracts the regex into a centralized ValidationConstants.java utility class in fineract-core and updates all references to use this single source of truth, improving maintainability.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made. (Note: Not applicable, as existing tests cover this refactor)
  • Follow our coding conventions
  • Add required Swagger annotation and update API documentation (Note: Not applicable, no API signatures changed)
  • This PR must not be a "code dump"
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.

@AshharAhmadKhan

Copy link
Copy Markdown
Contributor

@codigm please check the failures. Also another PR #5964 tried fixing the same issue, have a look at that as well for pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants