FINERACT-2621: Retry business date increase on concurrent initialization race - #6176
Open
avivijay19 wants to merge 1 commit into
Open
FINERACT-2621: Retry business date increase on concurrent initialization race#6176avivijay19 wants to merge 1 commit into
avivijay19 wants to merge 1 commit into
Conversation
…ion race INCREASE_BUSINESS_DATE_BY_1_DAY and INCREASE_COB_DATE_BY_1_DAY can run at the same time and both insert the initial m_business_date row, so one of them fails on a duplicate key. Run each increase in its own transaction and retry once when the first attempt is rolled back.
Contributor
|
@avivijay19 please check the failing log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #6069, where review asked for this to be raised in a separate PR since it is a pre-existing race, not something introduced by the Spring Boot upgrade.
INCREASE_BUSINESS_DATE_BY_1_DAYandINCREASE_COB_DATE_BY_1_DAYcan run at the same time, and whenm_business_datehas no row for a type yet, both jobs insert the initial row and one of them fails on a duplicate key. This surfaced as aSchedulerJobsTestfailure on a MySQL CI shard of #6069.increaseDateByTypeByOneDaynow runs in a transaction of its own, and the tasklets retry once when the first attempt is rolled back by the concurrent job.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.