FINERACT-2621: Add CI-only diagnostics for missing external events in e2e - #6175
Open
avivijay19 wants to merge 1 commit into
Open
FINERACT-2621: Add CI-only diagnostics for missing external events in e2e#6175avivijay19 wants to merge 1 commit into
avivijay19 wants to merge 1 commit into
Conversation
… e2e The buy down fee amortization event assertion times out intermittently in CI only, and the timeout alone cannot tell whether the event was never persisted to m_external_event or merely never delivered to the broker. On failure the step now queries the internal external events endpoint and logs which of the two stages lost the event. Enabled via EVENT_FAILURE_DIAGNOSTICS_ENABLED, off by default and set only in the e2e workflow, so passing runs are unaffected. Also retry loanAccountDataV1Check: earlier steps can raise events of the same type for the same loan, and assertEvent consumes the latest one received, which is a stale predecessor while the newest event is still in transit. Each attempt consumes one event, so retrying waits for the next one to arrive.
avivijay19
force-pushed
the
FINERACT-2621/e2e-event-failure-diagnostics
branch
from
July 25, 2026 07:37
05e29a1 to
85f12c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #6069, where review asked for these e2e changes to be raised in a separate PR since they are not part of the Spring Boot upgrade itself.
m_external_eventor was persisted but never delivered to the broker. A timeout alone cannot tell these two stages apart, which makes intermittent CI failures hard to attribute. Controlled byEVENT_FAILURE_DIAGNOSTICS_ENABLED, off by default and set only in the e2e workflow, and it only runs after an assertion has already failed, so passing runs are unaffected.loanAccountDataV1Checkconsumes the latest received event of the asserted type, which can be a stale predecessor when earlier steps raised events of the same type for the same loan. The verification is now retried so each attempt consumes the next event as it arrives.Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.