FINERACT-2705: Skip journal entries with unresolved GL accounts in savings interest posting job - #6174
Open
Abhishek6122008 wants to merge 1 commit into
Conversation
…vings interest posting job batchUpdateJournalEntries guarded journal-entry creation with the product-level SAVINGS_CONTROL and INTEREST_ON_SAVINGS mappings but inserted the transaction-level accounts resolved by selectAccountId, which uses accrual-only mappings (INTEREST_PAYABLE/INTEREST_RECEIVABLE). For cash-based products these resolve to 0, so the single-batch INSERT into acc_gl_journal_entry violates its foreign key and rolls back interest posting for every account in the tenant. Check the actual transaction-level accounts and skip unresolved ones with a warning instead of aborting the whole batch.
adamsaghy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.