Fix unused return value in LocalDateValidator (java:S2201) and improv…

[sherles1]

…e code documentation

Resolved the SonarCloud issue (rule java:S2201) where the result of LocalDateTime.parse() was being ignored in LocalDateValidator. The method toLocalDate() now returns the parsed LocalDateTime, ensuring the return value is used and improving the reliability of date validation.

Additionally, detailed comments have been added throughout the validator to clarify the purpose of each step, explain the use of reflection, document the formatter configuration, and improve overall readability for future contributors.

These changes enhance maintainability and align the implementation with static analysis requirements.

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[IOhacker]

• Access Apache Fineract Jira and assign yourself the ticket
• Comment that you are working on it
• Request feedback
• Fork the Apache Fineract repository
• Do the proper changes
• Run the Spotless Apply (it is possible that it should be run in different projects/modules)
• Build in your local dev environment and confirm that there are no issues
• Sign the commit and set the comment using the "FINERACT-{NUMBER}: {Jira text title}"
• Create the Pull request, make sure to name the PR "FINERACT-{NUMBER}: {Jira text title}" (it is verified as part of the GitHub Actions)
• Please be patient, there are several PRs at this moment and it is possible that we will request to do rebase
• Let us know for the review

[adamsaghy]

> Task :fineract-validation:checkstyleMain FAILED
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-validation/src/main/java/org/apache/fineract/validation/constraints/LocalDateValidator.java:54: Line has trailing spaces. [RegexpSingleline]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-validation/src/main/java/org/apache/fineract/validation/constraints/LocalDateValidator.java:89: Line has trailing spaces. [RegexpSingleline]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-validation/src/main/java/org/apache/fineract/validation/constraints/LocalDateValidator.java:90: Line has trailing spaces. [RegexpSingleline]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-validation/src/main/java/org/apache/fineract/validation/constraints/LocalDateValidator.java:91: Line has trailing spaces. [RegexpSingleline]
Error: eckstyle] [ERROR] /home/runner/work/fineract/fineract/fineract-validation/src/main/java/org/apache/fineract/validation/constraints/LocalDateValidator.java:96: Line has trailing spaces. [RegexpSingleline]