Skip to content

FINERACT-1371: Fix hook event payload exposing wrong resourceId for C…#5578

Open
SamaSVM wants to merge 1 commit intoapache:developfrom
SamaSVM:FINERACT-1371/fix-hook-event-resource-id-payload
Open

FINERACT-1371: Fix hook event payload exposing wrong resourceId for C…#5578
SamaSVM wants to merge 1 commit intoapache:developfrom
SamaSVM:FINERACT-1371/fix-hook-event-resource-id-payload

Conversation

@SamaSVM
Copy link
Contributor

@SamaSVM SamaSVM commented Mar 3, 2026

Description

Fix hook event payload incorrectly exposing resourceId equal to clientId for single-row CLIENT datatable entries

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@SamaSVM SamaSVM force-pushed the FINERACT-1371/fix-hook-event-resource-id-payload branch from eb94595 to c182a09 Compare March 4, 2026 10:47
this.officeId = officeId;
}

public void setResourceId(Long resourceId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using Lombok ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I’ve updated it.

@SamaSVM SamaSVM force-pushed the FINERACT-1371/fix-hook-event-resource-id-payload branch from c182a09 to 9567e5e Compare March 6, 2026 10:47
@SamaSVM SamaSVM force-pushed the FINERACT-1371/fix-hook-event-resource-id-payload branch from 0d793a7 to 98b2ad0 Compare March 6, 2026 12:30
@SamaSVM SamaSVM requested a review from IOhacker March 6, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants