Repository navigation
Conversation
Generated-by: OpenAI Codex
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
What does this PR do?
Honor the existing series cursor setting on heatmap cells, with optional per-item overrides.
Fixed issues
Closes #20569.
Details
Before: What was the problem?
HeatmapView created cell rectangles without applying cursor. With a series cursor of
crosshairand a first-item cursor ofhelp, all cells still usedpointer. On the unmodified base, 18 cursor configuration tests failed while six default-behavior tests passed.After: How does it behave after the fixing?
The shared grid-like rendering path reads the series cursor once, resolves per-item values through existing item-model inheritance, and forwards the value to the rectangle, following Symbol and other series.
This covers Cartesian, calendar, and matrix cells in normal and progressive Canvas rendering, and normal SVG rendering. Item overrides do not leak into following tuple or object items. Clearing only the series cursor preserves item overrides; clearing it and replacing data with tuples restores pointer.
SeriesOptionalready declaresseries.cursor. Addingdata[i].cursoris a backward-compatible public type and runtime extension for heatmap, using existing cursor semantics. Geo heatmaps remain silent raster images; this change does not add per-point interaction. Production code changes are three lines in HeatmapView and one data-item type declaration.Document Info
A companion English and Chinese documentation draft is available at apache/echarts-doc#540. It covers series and item cursor options, inheritance, supported coordinates, progressive rendering, and the geo limitation, with version markers for the current 6.1.0 development version.
Validation
Locally on macOS with Node 22.14.0:
build:lib,checktype, and a strict consumer check of generated heatmap declarations passed.git diff --checkpassed.The initial lint run overlapped with declaration generation and reported six BMap diagnostics. Later full uncached checks passed without changing BMap. Incomplete generated types are a suspected cause, not a confirmed diagnosis.
Not run locally: the full visual comparison suite, complete release packaging, the full supported TypeScript-version matrix, or the Node 20 CI environment. CI results are not claimed here.
Misc
Security Checking
ZRender Changes
Related test cases
test/heatmap-cursor.htmltest/ut/spec/series/heatmap.test.tstest/types/esm/heatmap.tsOther information
Implementation, tests, and this description were prepared with OpenAI Codex. Submitted as a draft for maintainer review.