Repository navigation
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Add an opt-in per-datum smoothing seam so a line stays connected but smoothing restarts at that vertex.
Fixed issues
Details
Before: What was the problem?
smooth: trueuses samples on both sides of a vertex when it places control points. A series that is one legend entry and one axis tooltip cannot keep a real join, such as history against a forecast, from being rounded through. Splitting the series in two splits the legend and the tooltip.nullwithconnectNulls: falsealready lifts the pen.markLineonly annotates. This is a corner, not a gap.Not this... (gaps)
After: How does it behave after the fixing?
{ value: 80, smoothBreak: true }keeps the vertex on the stroke and restarts smoothing there. Each side is smoothed as if that vertex were the end of the piece. The default series is unchanged.The flag is read only from a
series.dataobject. Numbers,[x, y]tuples, and dataset rows cannot carry it.stepignores it, because stepping rebuilds the point list. A seam on a sample thatsamplingdrops disappears with that sample. The stacked area seams the top edge of this series only, not the baseline from another series. During an update, the flag stays on the morphed vertex and uses the target datum for the whole animation.smoothMonotone: 'x'and'y'already use an axis-aligned tangent at every sample, so a seam often does not change those modes. The visual case usessmooth: true.Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/line-smooth-break.htmltest/ut/spec/chart/line/smoothBreak.test.tsMerging options
Other information
The name
smoothBreakis open to change. It is not a gap.