fix: Make axis.min/max behave consistently with series.data and axis.dataMin/Max#21638
Open
100pah wants to merge 1 commit into
Open
fix: Make axis.min/max behave consistently with series.data and axis.dataMin/Max#21638100pah wants to merge 1 commit into
100pah wants to merge 1 commit into
Conversation
…dataMin - illegal values are ignored. The previous behavior (before v6.1.0) is partially reasonable: `axis.min/max: NaN` coincidentally results in correct series rendering but abnormal axisLabel rendering, and cause axis extent to be series min/max. v6.1.0 introduces a breaking - `axis.min: NaN` causes axis to be blank and series not to be rendered. The current behavior is both reasonable and the closest to previous behavior.
|
Thanks for your contribution! The pull request is marked to be To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Make
axis.min/maxbehave consistently with the handling toseries.dataandaxis.dataMin/Max- illegal values are ignored.axis.min/max: NaNcoincidentally results in correct series rendering but abnormal axisLabel rendering, and cause axis extent to be series min/max.axis.min: NaNcauses axis to be blank and series not to be rendered, which is not preferable, since some existing usage accidentally passNaN, yet the chart still be renders.