Keep processing a batch when one queued item throws - #16470
Open
LI123456mo wants to merge 1 commit into
Open
LI123456mo wants to merge 1 commit into
LI123456mo wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16470 +/- ##
============================================
+ Coverage 60.91% 60.93% +0.01%
- Complexity 11769 11778 +9
============================================
Files 1953 1953
Lines 89275 89292 +17
Branches 13474 13474
============================================
+ Hits 54382 54409 +27
+ Misses 29312 29302 -10
Partials 5581 5581
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16469
What is the purpose of the change
When handling one item of a batch threw inside BatchExecutorQueue, the rest of the batch had already been taken off the queue and was silently dropped. TripleWriteQueue only handled CompletionException, so any other failure left the failing command's promise pending, and a failing last command skipped the channel flush for the earlier writes in the same batch.
Brief changelog
Verifying this change
Added BatchExecutorQueueTest and TripleWriteQueueTest covering failures in the middle, at the end, at a chunk boundary and multiple failures in one batch, executor rejection, promise completion, and flushing after a failing last command.