Fix #16295: JSON SPI loading without optional dependencies#16385
Open
larrychen1024 wants to merge 1 commit into
Open
Fix #16295: JSON SPI loading without optional dependencies#16385larrychen1024 wants to merge 1 commit into
larrychen1024 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16385 +/- ##
=========================================
Coverage 60.86% 60.87%
- Complexity 11763 11773 +10
=========================================
Files 1953 1953
Lines 89262 89262
Branches 13471 13471
=========================================
+ Hits 54331 54338 +7
- Misses 29329 29336 +7
+ Partials 5602 5588 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Fixes #16295.
On JDK 25,
ServiceLoader.Iterator#hasNext()may resolve a JSON provider's constructor and its referenced types. If an optional JSON implementation such as Gson is not present, this can throwNoClassDefFoundErrorbefore Dubbo can continue to the default fastjson2 implementation.Brief changelog
ServiceLoader#hasNext(), provider construction, and support checks inside the guarded iteration.ServiceConfigurationError,LinkageError, or provider runtime exceptions.Throwablecatch.Verifying this change
NoClassDefFoundError: com/google/gson/JsonSyntaxExceptionlocally on Temurin JDK 25.0.3 with the Dubbo 3.3.6 loading logic and Gson removed from the runtime classpath.FastJson2Implwithout Gson on JDK 25.0.3 and JDK 26.0.1.JsonUtilsTest: 6 tests passed on JDK 25.0.3.