[Bug][Spring Boot] Fix AwaitingNonWebApplicationListener await() with parent context#15890
[Bug][Spring Boot] Fix AwaitingNonWebApplicationListener await() with parent context#15890ishankhemani wants to merge 0 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15890 +/- ##
============================================
- Coverage 60.75% 60.74% -0.01%
- Complexity 11703 11705 +2
============================================
Files 1938 1938
Lines 88694 88697 +3
Branches 13387 13388 +1
============================================
- Hits 53886 53879 -7
- Misses 29275 29287 +12
+ Partials 5533 5531 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
’ve pushed an update to address the failing test. The test has been simplified and corrected to properly validate AwaitingNonWebApplicationListener behavior with a parent context. All tests pass locally now. Please let me know if any further adjustments are needed. |
|
Looks like this PR was coded by AI. I don’t understand why there are so many meaningless changes. |
RainYuY
left a comment
There was a problem hiding this comment.
Looks like this PR was coded by AI. I don’t understand why there are so many meaningless changes.
44e87ee to
703290d
Compare
Changes made:
AwaitingNonWebApplicationListener.java
Updated await() logic to correctly handle parent contexts.
Ensures that await() completes even if the application context is not a root context.
AwaitingNonWebApplicationListenerTest.java
Rewrote the test to simulate a parent-child application context scenario.
Added an assertion to verify that await() completes successfully with a parent context.
pom.xml (dubbo-spring-boot)
Updated Maven Surefire plugin configuration to ensure JUnit Jupiter tests are executed properly.
Why this is important:
Fixes a blocking issue in non-web Spring Boot applications using Dubbo with a bootstrap parent context.
Improves test coverage to catch similar issues in the future.
Ensures consistent behavior of Dubbo application lifecycle handling.
Testing done:
Verified that AwaitingNonWebApplicationListenerTest passes locally with the updated logic.
Build succeeds with all existing tests.
Fixes #13722
please review this pr when you get time respected sir @RainYuY @AlbumenJ @AlexStocks