fix: delegate row/vector id inspectors for clustered selector factories#19702
Open
clintropolis wants to merge 2 commits into
Open
fix: delegate row/vector id inspectors for clustered selector factories#19702clintropolis wants to merge 2 commits into
clintropolis wants to merge 2 commits into
Conversation
capistrant
approved these changes
Jul 17, 2026
FrankChen021
left a comment
FrankChen021
left a comment
Member
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 1 |
| P2 | 1 |
| P3 | 0 |
| Total | 2 |
Reviewed 4 of 4 changed files.
Found two ID-remapping collision risks when row or vector IDs are non-monotonic.
This is an automated review by Codex GPT-5.6-Sol
capistrant
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an oversight with
ClusteringColumnSelectorFactory/ClusteringVectorColumnSelectorFactorywith rowid supplier/vector inspector, which were incorrectly being pulled from the current delegate instead of delegating to the current delegate.