feat: Add lag/idle plot simulator for cost-based autoscaler#19687
Draft
kfaraz wants to merge 6 commits into
Draft
feat: Add lag/idle plot simulator for cost-based autoscaler#19687kfaraz wants to merge 6 commits into
kfaraz wants to merge 6 commits into
Conversation
kfaraz
commented
Jul 15, 2026
| } | ||
|
|
||
| @GET | ||
| @Path("/{id}/autoscaler") |
Contributor
Author
There was a problem hiding this comment.
We will rename this API based on what we decide the final result set to look like:
Suggested change
| @Path("/{id}/autoscaler") | |
| @Path("/{id}/autoscaler/simulate") |
Comment on lines
+544
to
+548
| @QueryParam("taskCountMin") int taskCountMin, | ||
| @QueryParam("taskCountMax") int taskCountMax, | ||
| @QueryParam("maxProcessingRatePerTask") int maxProcessingRatePerTask, | ||
| @QueryParam("optimalTaskIdleRatio") double optimalTaskIdleRatio, | ||
| @QueryParam("criticalLag") int criticalLag, |
Contributor
Author
There was a problem hiding this comment.
Instead of multiple query params, we should just be able to send a POST payload object as a CostBasedAutoScalerConfig.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @QueryParam("idleWeight") Double idleWeight, | ||
| @QueryParam("criticalLag") int criticalLag, | ||
| @QueryParam("currentTaskCount") Integer currentTaskCount, | ||
| @Context HttpServletRequest request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tuning the lag-based auto-scaler can sometimes be a little involved.
This patch aims to allow making the process simpler by simulating the optimal task count chosen by the auto-scaler under different conditions.
Changes currently in this PR
CostBasedAutoScalerin "simulate" mode and generates the optimal task count for various input values of lag (based on criticalLag)Web-console screenshot
Other required changes
autoscalerConfigmay be sent as payloadautoscalerConfigand vice versataskIdleRatiofield to accept decimal numbers, currently the field resets to integersThis PR has: