Enabled filtering of metrics in the LoggingEmitter#19026
Open
nozjkoitop wants to merge 5 commits intoapache:masterfrom
Open
Enabled filtering of metrics in the LoggingEmitter#19026nozjkoitop wants to merge 5 commits intoapache:masterfrom
nozjkoitop wants to merge 5 commits intoapache:masterfrom
Conversation
9 tasks
Contributor
|
Thanks @nozjkoitop for the contribution! Cross-linking the comment here on a similar implementation - #19030 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19021.
Description
Added metric filtering support for LoggingEmitter with a default allowlist and optional override path.
Configuration
druid.emitter.logging.filterMetrics(default false) to gate metric filteringdruid.emitter.logging.metricAllowlistPathto optionally load a custom allowlist fileDefault allowlist now lives in
defaultLoggingMetricNames.jsonand is used when no custom path is provided. Format is simplified to a JSON array of metric names. If a custom allowlist path is configured but missing, emitter falls back to the default built-in allowlist.Release note
LoggingEmittercan now optionally filter metric logs by an allowlist, which helps reduce log volume on busy clusters while keeping non-metric events unchanged. Enable filtering withdruid.emitter.logging.filterMetrics=true, and optionally pointdruid.emitter.logging.metricAllowlistPathto a JSON with metrics to include, if the custom file is missing, Druid automatically falls back to the built-in default allowlist.This PR has: