Skip to content

DRILL-8550: Fix Flaky Splunk Tests #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cgivre merged 1 commit into from
Jul 22, 2026
+18 −6
Merged

DRILL-8550: Fix Flaky Splunk Tests #3060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions contrib/storage-splunk/src/test/java/org/apache/drill/exec/store/splunk/SplunkTestSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,22 @@ private static java.io.File createDefaultYmlFile() {
}
}

// Pin the patch version. "splunk/splunk:9.3" is a mutable tag; it was
// republished on 2026-07-01 and silently broke CI on every branch. Bump this
// deliberately so an upstream push can never turn the build red on its own.
//
// Talk to splunkd over its default HTTPS listener rather than setting
// SPLUNKD_SSL_ENABLE=false. Disabling splunkd SSL is a path Splunk has
// regressed repeatedly (see splunk/docker-splunk#639, still open), and it
// broke again in 9.3.14. The container's cert is self-signed, so the plugin
// configs below turn off certificate and hostname validation.
@ClassRule
public static GenericContainer<?> splunk = new GenericContainer<>(
DockerImageName.parse("splunk/splunk:9.3")
DockerImageName.parse("splunk/splunk:9.3.14")
)
.withExposedPorts(8089, 8089)
.withEnv("SPLUNK_START_ARGS", "--accept-license")
.withEnv("SPLUNK_PASSWORD", SPLUNK_PASS)
.withEnv("SPLUNKD_SSL_ENABLE", "false")
.withCopyFileToContainer(
org.testcontainers.utility.MountableFile.forHostPath(
createDefaultYmlFile().toPath()
Expand Down Expand Up @@ -159,8 +167,11 @@ public static void initSplunk() throws Exception {
StoragePluginRegistry pluginRegistry = cluster.drillbit().getContext().getStorage();
SPLUNK_STORAGE_PLUGIN_CONFIG = new SplunkPluginConfig(
SPLUNK_LOGIN, SPLUNK_PASS,
"http", hostname, port,
null, null, null, null, false, true, // app, owner, token, cookie, validateCertificates
"https", hostname, port,
// app, owner, token, cookie, validateCertificates, validateHostname.
// The container serves a self-signed cert for a hostname that never matches
// the mapped localhost port, so both checks must be off.
null, null, null, null, false, false,
"1", "now",
null,
4,
Expand All @@ -181,8 +192,9 @@ public static void initSplunk() throws Exception {

SPLUNK_STORAGE_PLUGIN_CONFIG_WITH_USER_TRANSLATION = new SplunkPluginConfig(
null, null, // username, password
"http", hostname, port,
null, null, null, null, false, false, // app, owner, token, cookie, validateCertificates
"https", hostname, port,
// app, owner, token, cookie, validateCertificates, validateHostname
null, null, null, null, false, false,
"1", "now",
credentialsProvider,
4,
Expand Down
Loading