Conversation
…pache#66815) ### What problem does this PR solve? Extract aggregate-argument CSE below distribute
…_agg_distribute suite branch-4.2 has no bucketed hash aggregate, so `enable_bucketed_hash_agg` does not exist on this branch; the suite's plan/result checks pass without it.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #66815 to branch-4.2
fe Extract aggregate-argument CSE below distribute
The upstream patch refactors the inline CSE logic into a
projectAggregateCsehelper(a cosmetic refactor that branch-4.2 does not have) and adds the new
PhysicalDistributebranch; the pick keeps branch-4.2's inline structure and adds thebehavioural change only.
branch-4.2 has no bucketed hash aggregate, so the new suite's
set enable_bucketed_hash_agg=falseline was replaced by a comment; the remainingplan and result checks pass on this branch (VEXCHANGE + VSELECT with 4 references to
the extracted
cast(a as BIGINT) + cast(b as BIGINT)slot).Testing: nereids_rules_p0/agg_strategy/cse_agg_distribute passes on a branch-4.2 FE.