branch-4.0：[test](fe) Isolate cloud frontend service test- #65577 #65577 - #66381
Merged
Conversation
Issue Number: None
Related PR: None
Problem Summary: FrontendServiceImplTest starts a non-cloud mocked FE and BE. testGetTabletReplicaInfosNullJobReturnsCancelledWithoutNpe temporarily enabled cloud mode through Config.cloud_unique_id, allowing the shared background heartbeat thread to take a cloud-only path and mark the mock BE dead. Move this cloud-specific test into a dedicated class without the mocked FE/BE fixture, while preserving the same getTabletReplicaInfos cancellation assertions.
None
- Test: Unit Test
- ./run-fe-ut.sh --run org.apache.doris.service.FrontendServiceImplCloudTest
- ./run-fe-ut.sh --run org.apache.doris.service.FrontendServiceImplTest
- Behavior changed: No
- Does this need documentation: No
(cherry picked from commit 666eec9)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
0AyanamiRei
changed the title
Contributor
Author
|
run buildall |
morningman
previously approved these changes
Aug 3, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
FE Regression Coverage ReportIncrement line coverage |
### What problem does this PR solve? Issue Number: None Related PR: apache#65577 Problem Summary: The branch-4.0 backport moves the cloud-specific getTabletReplicaInfos test out of FrontendServiceImplTest so it cannot disturb the shared mock backend. Unlike master, branch-4.0 initializes ThriftServerEventProcessor connection context only when a Thrift server is constructed. The standalone test therefore failed before reaching the removed warm-up job path. Mock the absent connection context within the test so it preserves the CANCELLED response coverage without changing production behavior. ### Release note None ### Check List (For Author) - Test: Unit Test - ./run-fe-ut.sh --run org.apache.doris.service.FrontendServiceImplCloudTest,org.apache.doris.service.FrontendServiceImplTest - Behavior changed: No - Does this need documentation: No
Contributor
Author
|
run buildall |
github-actions
Bot
removed
the
approved
Contributor
Author
|
run buildall |
morningman
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick from #65577