[chore](skill) Add nullable handling AI review rules#64442
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
Author
|
run buildall |
Contributor
There was a problem hiding this comment.
Review result: no blocking issues found.
Critical checkpoint conclusions:
- Goal and proof: This PR adds high-priority BE nullable/ColumnConst review rules to
.claude/skills/code-review/SKILL.md. The added guidance matches the actual core column behavior I checked:is_column_nullable()is a concreteColumnNullabletype check,ColumnConst::is_nullable()can report nullable when its nested data is nullable, andremove_nullable(ColumnConst(ColumnNullable(T)))preserves the const wrapper asColumnConst(T). No runtime test is required for this documentation-only skill update;git diff --checkpassed. - Scope: The modification is small and focused: one review skill file, 9 added lines.
- Concurrency: Not applicable; no runtime code, shared state, locks, or thread entry points changed.
- Lifecycle/static initialization: Not applicable; no C++ objects or initialization paths changed.
- Configuration: Not applicable; no config item changed.
- Compatibility/storage/protocol: Not applicable; no function symbols, storage formats, Thrift fields, FE-BE protocol, or persisted metadata changed.
- Parallel paths: The existing function-system null-handling checklist remains valid; the new section generalizes the same nullable/const-column trap for BE column review and does not conflict with it.
- Conditions/error handling/memory/data correctness/observability/performance: Not runtime-affecting. The guidance accurately targets review-time risks around nullable column shape, const materialization, and invariant handling.
- Tests and result files: No regression, unit, or
.outfiles are changed, which is appropriate for this skill/documentation-only PR. - User focus: No additional user-provided review focus was present.
csun5285
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup of #64407